Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Fix inventory table pagination on location filter change #3479

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

StephixOne
Copy link
Contributor

@StephixOne StephixOne commented Mar 15, 2023

Inventory table offset should now correctly reset when a new location is selected from the filtering dropdown.

Resolves CORE-1231.

@StephixOne StephixOne requested a review from a team as a code owner March 15, 2023 10:13
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 71ffd60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 0:12AM (UTC)

@StephixOne
Copy link
Contributor Author

@srindom From just a quick attempt, I was not able to reproduce the second bug you mentioned on the ticket, or I misunderstood it. Please advise if it's still happening and I'll try again ^^

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 8e78c53 into develop Mar 15, 2023
@kodiakhq kodiakhq bot deleted the fix/inventory-table-pagination branch March 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants