Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(medusa): handle reservation quantity update for line items #3484

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Feat(medusa): handle reservation quantity update for line items #3484

merged 3 commits into from
Mar 16, 2023

Conversation

pKorsholm
Copy link
Contributor

What

  • Raise exception if a reservation is updated or created to have larger quantity than is unfulfilled for a line-item

Fixes CORE-1249

@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 9:04AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb44dc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pKorsholm pKorsholm marked this pull request as ready for review March 15, 2023 15:37
@pKorsholm pKorsholm requested a review from a team as a code owner March 15, 2023 15:37
srindom
srindom approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 38c8d49 into develop Mar 16, 2023
@kodiakhq kodiakhq bot deleted the feat/raise-exception-in-core-if-reservation-quantity-exceeds-available-quantity branch March 16, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pKorsholm @srindom