Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Add event emitter to ProductCollectionService #3495

Conversation

davorbacic
Copy link
Contributor

Closes #3494

@davorbacic davorbacic requested review from a team as code owners March 16, 2023 12:26
@vercel
Copy link

vercel bot commented Mar 16, 2023

@davorbacic is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: ff919e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davorbacic davorbacic changed the base branch from master to develop March 16, 2023 12:26
@vercel
Copy link

vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 6:05PM (UTC)

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @davorbacic - thanks for the contribution!

Changes look good. Will let the pipeline do its job and then we can proceed 💪

@olivermrbl olivermrbl changed the title Add event emitter to ProductCollectionService feat(medusa): Add event emitter to ProductCollectionService Mar 16, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks guys ❤️

@olivermrbl olivermrbl merged commit fe4b8fe into medusajs:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProductCollectionService doesn't emit events
2 participants