Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-ui): show failure reason for batch jobs #3526

Merged
merged 6 commits into from
Mar 21, 2023
Merged

fix(admin-ui): show failure reason for batch jobs #3526

merged 6 commits into from
Mar 21, 2023

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Mar 20, 2023

What

  • show the failure reason in the upload modal if the batch job fails
  • fetch failed jobs for the activity drawer and show errors as well
  • template CSVs removed in the migration were restored

Screenshot 2023-03-20 at 14 37 51

Screenshot 2023-03-20 at 14 55 18

FIXES CORE-1175

@fPolic fPolic requested a review from olivermrbl March 20, 2023 14:07
@fPolic fPolic requested a review from a team as a code owner March 20, 2023 14:07
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 005c1ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 3:18PM (UTC)

adrien2p
adrien2p approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition

olivermrbl
olivermrbl requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the tooltip slightly wider?

CleanShot 2023-03-20 at 18 26 45@2x

packages/admin-ui/ui/src/components/organisms/upload-modal/index.tsx Outdated Show resolved Hide resolved
@fPolic fPolic requested a review from olivermrbl March 20, 2023 17:44
kasperkristensen
kasperkristensen approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit f831b7d into develop Mar 21, 2023
@olivermrbl olivermrbl deleted the fix/batch-jobs-error-reporting branch March 21, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@kasperkristensen kasperkristensen kasperkristensen approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fPolic @adrien2p @kasperkristensen @olivermrbl