Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Remove reservations for all line items when an order edit is accepted #3544

Merged
merged 7 commits into from
Mar 30, 2023
Merged

feat(medusa): Remove reservations for all line items when an order edit is accepted #3544

merged 7 commits into from
Mar 30, 2023

Conversation

pKorsholm
Copy link
Contributor

What

  • Remove all allocations to line items once an order edit is confirmed

Why

  • Since all line items of an order are discarded once an order edit is confirmed it will orphan the reservations causing inconsistencies with the stock

@pKorsholm pKorsholm requested a review from a team as a code owner March 21, 2023 16:20
@vercel
Copy link

vercel bot commented Mar 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 30, 2023 at 8:25AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 409813e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Minor
@medusajs/admin-ui Patch
@medusajs/admin Major
@medusajs/medusa-js Major
medusa-payment-paypal Major
medusa-payment-stripe Major
medusa-plugin-restock-notification Major
medusa-react Major
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pKorsholm pKorsholm force-pushed the feat/remove-reservations-for-line-items-when-confirming-order-edit branch 2 times, most recently from 96cf35b to e42d8df Compare March 26, 2023 11:27
@olivermrbl olivermrbl changed the title Feat(medusa): Remove reservations for all line items when an order edit is accepted feat(medusa): Remove reservations for all line items when an order edit is accepted Mar 28, 2023
srindom
srindom requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an integration test

@pKorsholm pKorsholm force-pushed the feat/remove-reservations-for-line-items-when-confirming-order-edit branch from db0090c to 945343f Compare March 29, 2023 14:43
@olivermrbl olivermrbl requested a review from srindom March 29, 2023 17:39
olivermrbl
olivermrbl approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fPolic
fPolic approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

srindom
srindom approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 5e405be into develop Mar 30, 2023
@kodiakhq kodiakhq bot deleted the feat/remove-reservations-for-line-items-when-confirming-order-edit branch March 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@fPolic fPolic fPolic approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pKorsholm @srindom @fPolic @olivermrbl