Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa, modules-sdk): default module error message #3605

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:
If a module is required and it has a default package, warn the user to install it if not found.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner March 28, 2023 12:11
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 2561454

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@medusajs/modules-sdk Patch
@medusajs/medusa Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/inventory Patch
@medusajs/admin Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 28, 2023 at 0:45AM (UTC)

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 💯

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition 💪

@adrien2p
Copy link
Member

I think we Should we add a new test for this scenario

@carlos-r-l-rodrigues
Copy link
Contributor Author

@patrick-medusajs Am I missing something that unit tests of OAS is failing?

@patrick-medusajs
Copy link
Contributor

@patrick-medusajs Am I missing something that unit tests of OAS is failing?

Weird, I can not explain it. I'm pulling the branch to have a look.

@olivermrbl olivermrbl merged commit bca1f80 into develop Mar 28, 2023
@olivermrbl olivermrbl deleted the chore/error-missing-default-module branch March 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants