fix(oas:test): Augment jest timeout from 30 to 60 sec #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99af01e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
patrick-medusajs
force-pushed
the
fix/oas-flaky-test
branch
from
10e99c7
to
298fa78
Compare
olivermrbl
approved these changes
Mar 30, 2023
olivermrbl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix flaky test in CI by augmenting jest timeout config from 30 seconds to 60 seconds.
How
With our current version of
jest, timeouts and errors thrown inbeforeAllwith async are swallowed. Failure in beforeAll execution won't prevent the rest of the test suite to run, which will fail in unexpected ways. Until we upgradejestfrom version 25 to something like 29, issues surrounding beforeAll will remain difficult to troubleshoot.