Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added a services constraint document #8999

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

shahednasser
Copy link
Member

  • Added a services constraint document mentioning that a service's methods must be async.
  • Modify the code in the services intro document to use async method.

@shahednasser shahednasser requested a review from a team as a code owner September 4, 2024 15:46
Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: fd1fa8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 11:54am

@kodiakhq kodiakhq bot merged commit 1466ca7 into develop Sep 10, 2024
32 checks passed
@kodiakhq kodiakhq bot deleted the docs/service-constraints branch September 10, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants