Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Query documentation #9079

Merged
merged 7 commits into from
Sep 10, 2024
Merged

docs: add Query documentation #9079

merged 7 commits into from
Sep 10, 2024

Conversation

shahednasser
Copy link
Member

  • Replace remote query documentation with new Query documentation
  • Add redirect from old remote query to new query documentation
  • Update remote query usages across docs to use new query usage.

@shahednasser shahednasser requested a review from a team as a code owner September 10, 2024 10:56
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:32am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c402808

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

www/apps/resources/app/recipes/digital-products/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/recipes/marketplace/examples/restaurant-delivery/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/recipes/marketplace/examples/restaurant-delivery/page.mdx Outdated
@@ -682,7 +680,7 @@ This returns the list of restaurants in the response.

### Further Reads

- [What is Remote Query and how to use it](!docs!/advanced-development/modules/remote-query)
- [What is the Query and how to use it](!docs!/advanced-development/modules/query)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [What is the Query and how to use it](!docs!/advanced-development/modules/query)
- [What is Query and how to use it](!docs!/advanced-development/modules/query)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to go over it all and ensure it's Query and not the Query. Maybe we can do a search and replace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will do, it felt weird just naming it "Query" but let's test it out 😄

@kodiakhq kodiakhq bot merged commit e9b5f76 into develop Sep 10, 2024
30 of 32 checks passed
@kodiakhq kodiakhq bot deleted the docs/query branch September 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge team: medusa type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahednasser @olivermrbl