Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: joiner config entity property #9084

Merged
merged 19 commits into from
Sep 11, 2024
Merged

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Sep 10, 2024

What:

  • promote entity as a property of joiner config relashionships
  • defineLink - forward arguments on field aliases and small fixes

Breaking Change:

  • rename Customer module Address related methods to CustomerAddress (e.g: listCustomerAddress)

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 9:10am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 11, 2024 9:10am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:10am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:10am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:10am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:10am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 9:10am

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 999f447

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you think we should make the entity required? It will always refers to a type in the graphql in theory (even though not in the db) wdyt?

@carlos-r-l-rodrigues
Copy link
Contributor Author

carlos-r-l-rodrigues commented Sep 11, 2024

LGTM, do you think we should make the entity required? It will always refers to a type in the graphql in theory (even though not in the db) wdyt?

I believe we can keep it optional, that way it is still possible to link a Module to other directly. Suppose module X have 10 entities containing field z_id, 1 single link from X to module Z would be enough.

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit fdd0543 into develop Sep 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants