Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): product create - ignored variants in datagrid #9087

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 10, 2024

What

  • When there are skipped variants, we are filtering the data array that is passed to the data grid. Cells in the data grid don't read passed data but instead look for the value from an index in the form field array. Since there is fewer elements in the provided data than in the variants array, indexes don't match.

FIXES CC-97

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 8:27am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 11, 2024 8:27am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 8:27am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 8:27am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 8:27am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 8:27am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 8:27am

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: f54a18e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic changed the title fix(dashboard): product create index mismatch in datagrid fix(dashboard): product create - ignored variants in datagrid Sep 11, 2024
@olivermrbl olivermrbl merged commit 42cedd0 into develop Sep 12, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/create-product-arrays-mismatch branch September 12, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants