Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instanceof MedusaError does not work #9107

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

McTom234
Copy link
Contributor

The same as #9094, but for v1. Our project won't be moving to v2 soon probably, and we want the feature of course 😄

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 9365c35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/utils Patch
@medusajs/promotion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 11, 2024

@McTom234 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

packages/utils/src/common/errors.ts Outdated Show resolved Hide resolved
@McTom234
Copy link
Contributor Author

Do we need a changeset here?

@riqwan
Copy link
Contributor

riqwan commented Sep 12, 2024

Do we need a changeset here?

yes, for v1 we do

@McTom234
Copy link
Contributor Author

Okay, cool! automerge means it's merged automatically?

@kodiakhq kodiakhq bot merged commit 7488562 into medusajs:v1.x Sep 12, 2024
19 of 26 checks passed
@McTom234 McTom234 deleted the fix/medusa-error-constructor-name branch September 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants