Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OrderDTO add first class discount_subtotal var #9112

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: OrderDTO add first class discount_subtotal var #9112

merged 1 commit into from
Sep 12, 2024

Conversation

420coupe
Copy link
Contributor

Include discount_subtotal as a first class var for OrderDTO

mentioned in PR #9002

@420coupe 420coupe requested a review from a team as a code owner September 12, 2024 02:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 9123dc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024

@420coupe is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@420coupe 420coupe changed the title add first class discount_subtotal var fix: add first class discount_subtotal var Sep 12, 2024
@420coupe 420coupe changed the title fix: add first class discount_subtotal var fix: OrderDTO add first class discount_subtotal var Sep 12, 2024
riqwan
riqwan approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @420coupe!

@riqwan riqwan merged commit 4471b25 into medusajs:develop Sep 12, 2024
14 of 22 checks passed
@420coupe 420coupe deleted the fix/OrderDTO-discount_subtotal branch September 13, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@420coupe @riqwan