chore: remove container registration name

[carlos-r-l-rodrigues]

What:

• Deprecated ModuleRegistrationName in favor of Modules enum
• Modules are always registered in the container using their key
• Modules' key name normalized to PascalCase and Service suffix was removed (breaking change if module is resolved using strings)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 16, 2024 7:27am

6 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)			Sep 16, 2024 7:27am
api-reference-v2	⬜️ Ignored (Inspect)	Visit Preview		Sep 16, 2024 7:27am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Sep 16, 2024 7:27am
docs-v2	⬜️ Ignored (Inspect)	Visit Preview		Sep 16, 2024 7:27am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 16, 2024 7:27am
resources-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 16, 2024 7:27am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8bd4b40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[adrien2p]

LGTM, we might need a release note for that :D

[sradevski]

Really nice cleanup! Q: Are we also cleaning up the ContainerRegistrationKeys?

[carlos-r-l-rodrigues]

Really nice cleanup! Q: Are we also cleaning up the ContainerRegistrationKeys?

Yeah, I think we need. I haven't done in this PR because I dont have any good naming suggestion.

[carlos-r-l-rodrigues]

@olivermrbl, let me know if we can merge this one.

[olivermrbl]

Yes, all good

[olivermrbl]

Maybe ContainerRegistrationKeys could be split into something like Resources and Tools:

const query = container.resolve(Tools.QUERY)
const logger = container.resolve(Tools.LOGGER)
const linker = container.resolve(Tools.REMOTE_LINK) // might want to rename this at some point?

const pgConnection = container.resolve(Resources.PG_CONNECTION)
const config = container.resolve(Resources.CONFIG)

Hard to find a single term that encapsulates all, because of how different these all are.