Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fixes to HTTP types #9189

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(types): fixes to HTTP types #9189

merged 3 commits into from
Sep 19, 2024

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Sep 19, 2024

  • Change countries in AdminRegion to be of type AdminRegionCountry
  • Change inventory_item's type in AdminReturn to AdminInventoryItem
  • Use ReturnStatus enum as type of status in BaseReturn.
  • Add @ignore tsdocs to FE-related fields in the BaseRuleAttributeOptions type since we don't want to show it in the API reference
  • Change the operator type in AdminShippingOptionRule
  • Remove id from BaseRuleValueOptions because the API route doesn't return it
  • Remove incorrect properties of a tax region

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 2:47pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 19, 2024 2:47pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:47pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:47pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:47pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:47pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 2:47pm

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 281a70b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@olivermrbl olivermrbl merged commit 230a16a into develop Sep 19, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/http-types-2 branch September 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants