Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules-sdk): Fix dynamic import usage #9304

Merged
merged 4 commits into from
Sep 25, 2024
Merged

fix(modules-sdk): Fix dynamic import usage #9304

merged 4 commits into from
Sep 25, 2024

Conversation

adrien2p
Copy link
Member

What
Fix loading resources dynamically

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8267aca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 10:49am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 25, 2024 10:49am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 10:49am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 10:49am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 10:49am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 10:49am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 10:49am

@adrien2p adrien2p marked this pull request as ready for review September 25, 2024 09:47
@adrien2p adrien2p requested review from a team as code owners September 25, 2024 09:47
@adrien2p
Copy link
Member Author

/snapshot-this

@adrien2p
Copy link
Member Author

@riqwan Can you try this one please, it should fix the issues

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 1d3a600

@adrien2p
Copy link
Member Author

@riqwan can I merge this one?

@adrien2p adrien2p merged commit 74cdb9d into develop Sep 25, 2024
23 checks passed
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
fix(modules-sdk): Fix dynamic import usage (medusajs#9304)
a8a7bae 
* fix(modules-sdk): Fix dynamic import usage

* missing new line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @carlos-r-l-rodrigues