Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa,fulfillment): pass stock location data to fulfillment provider #9322

Merged
merged 8 commits into from
Sep 28, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Sep 26, 2024

What

  • Fetches the stock location's details when creating a fulfillment and return fulfillment.
  • Passes the data to the fulfillment module, which in turn passes it to the fulfillment provider.

Why

  • When creating a fulfillment in a multi-location setup the fulfillment provider will need to know where the package is being sent from (so the shipping service can pick it up).
  • Previously, we didn't pass anything but the location id to the fulfillment provider. Because the fulfillment provider can't have a dependency on the stock location module this was not sufficient.
  • This change ensures there is enough data passed to the fulfillment provider to build integrations properly.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 1:48pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 1:48pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:48pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:48pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:48pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:48pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:48pm

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 4e5503b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 17b2868 into develop Sep 28, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/location-data-to-fulfillment-provider branch September 28, 2024 14:01
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
…vider (medusajs#9322)

**What**
- Fetches the stock location's details when creating a fulfillment and return fulfillment.
- Passes the data to the fulfillment module, which in turn passes it to the fulfillment provider.

**Why**
- When creating a fulfillment in a multi-location setup the fulfillment provider will need to know where the package is being sent from (so the shipping service can pick it up). 
- Previously, we didn't pass anything but the location id to the fulfillment provider. Because the fulfillment provider can't have a dependency on the stock location module this was not sufficient. 
- This change ensures there is enough data passed to the fulfillment provider to build integrations properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants