fix: validate regions exist for shipping option price update #9364
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
| ContainerRegistrationKeys.REMOTE_QUERY | ||
| ) | ||
|
|
||
| let remoteQueryObject = remoteQueryObjectFromString({ |
There was a problem hiding this comment.
Q: nothing to do but should we start using the query graph api instead when writing new things?
There was a problem hiding this comment.
Yes happy to do that - do you have an example implementation somewhere that I can reference
There was a problem hiding this comment.
#9061
Should give some examples to look at. Let me know how it goes
There was a problem hiding this comment.
Will probably merge this for now - still happy to do a separate PR with the graph api to try it out though if you can share an example :)
packages/core/core-flows/src/fulfillment/steps/validate-shipping-option-prices.ts
Outdated
Show resolved
Hide resolved
packages/core/core-flows/src/fulfillment/steps/validate-shipping-option-prices.ts
Show resolved
Hide resolved
…s#9364) **What** - Adds a step to `updateShippingOptionsWorkflow` and `createShippingOptionsWorkflow` that validates if the region prices being updated have corresponding regions configured. **Why** - Previously, if you tried to send a region price update for a region that had been deleted the backend would throw an error when attempting to insert the region price. The error comes from a not-null constraint in the db, but it is better to validate that the regions we are trying to create prices for exist. Fixes CC-542
What
updateShippingOptionsWorkflowandcreateShippingOptionsWorkflowthat validates if the region prices being updated have corresponding regions configured.Why
Fixes CC-542