Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve mikro orm serializer circular ref and link serialization #9411

Merged
merged 18 commits into from
Oct 3, 2024
Merged

chore: improve mikro orm serializer circular ref and link serialization #9411

merged 18 commits into from
Oct 3, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 1, 2024 •
edited
Loading

What

  • improve data serialization wit mikro orm when it comes to detect circular reference to parent entities
  • change serialization strategy for link as they do not contains special entity treatment or anything specific

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:07pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:07pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:07pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:07pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:07pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:07pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 4:07pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b70c473

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 1, 2024 16:21
@adrien2p adrien2p requested a review from a team as a code owner October 1, 2024 16:21
@adrien2p adrien2p changed the title chore: Make mikro orm serializer async chore: improve mikro orm serializer circular ref and link serialization Oct 2, 2024
@adrien2p adrien2p merged commit 225d00c into develop Oct 3, 2024
23 checks passed
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
chore: improve mikro orm serializer circular ref and link serializati…
3bceea9 
…on (medusajs#9411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @carlos-r-l-rodrigues