feature: Add MikroORM CLI wrapper to bypass hardcoded module system #9426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
adrien2p
reviewed
Oct 2, 2024
adrien2p
approved these changes
Oct 2, 2024
olivermrbl
reviewed
Oct 2, 2024
riqwan
approved these changes
Oct 2, 2024
panalgin
pushed a commit
to vennyx-org/medusa
that referenced
this pull request
Oct 7, 2024
…edusajs#9426) FIXES: FRMW-2727 MikroORM (with version 5.9) has [hardcoded the TypeScript module](https:/mikro-orm/mikro-orm/blob/5.x/packages/core/src/utils/ConfigurationLoader.ts#L138-L139) system to `commonjs`, which makes it incompatible with the module system we are using, ie `Node16`. So, in order to continue using the Mikro ORM CLI within our modules, we will have to monkey-patch the block of code responsible for configuring `ts-node`. However, the monkey-patching must be done before their CLI gets booted. As a result of this, we have to create a wrapper CLI on top of Mikro ORM CLI that performs the following steps. - Monkey-patch the relevant code - Register Mikro ORM CLI as the second step. Due do this, we will have to use this new wrapper CLI within the modules, which is exposed as `medusa-db`. Maybe, `medusa-db` is not a great name, so please send your suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: FRMW-2727
MikroORM (with version 5.9) has hardcoded the TypeScript module system to
commonjs, which makes it incompatible with the module system we are using, ieNode16.So, in order to continue using the Mikro ORM CLI within our modules, we will have to monkey-patch the block of code responsible for configuring
ts-node. However, the monkey-patching must be done before their CLI gets booted.As a result of this, we have to create a wrapper CLI on top of Mikro ORM CLI that performs the following steps.
Due do this, we will have to use this new wrapper CLI within the modules, which is exposed as
medusa-db. Maybe,medusa-dbis not a great name, so please send your suggestions.