Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Processing filters deeply looking at the current joiner first #9428

Merged
merged 5 commits into from
Oct 2, 2024
Merged

chore: Processing filters deeply looking at the current joiner first #9428

merged 5 commits into from
Oct 2, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 2, 2024 •
edited
Loading

What

  • for deep filter first look at the parent filter joiner config before searching to any other joiner config to limit the risk of ambiguity
  • Temporarely remove check on entities map until we have graph for everything

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bf44b4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:46am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 2, 2024 11:46am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 11:46am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 11:46am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 11:46am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 11:46am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 11:46am

@adrien2p adrien2p marked this pull request as ready for review October 2, 2024 11:18
@adrien2p adrien2p requested a review from a team as a code owner October 2, 2024 11:18
@adrien2p adrien2p requested a review from riqwan October 2, 2024 11:20
@adrien2p
fix
ae33c13
@adrien2p
Merge branch 'chore/handle-ambiguous-module-relation-ships-filtering'…
bf44b4b 
… of github.com:medusajs/medusa into chore/handle-ambiguous-module-relation-ships-filtering
@adrien2p adrien2p merged commit 8753b17 into develop Oct 2, 2024
23 checks passed
panalgin pushed a commit to vennyx-org/medusa that referenced this pull request Oct 7, 2024
@adrien2p @panalgin
chore: Processing filters deeply looking at the current joiner first (m…
774d0d8 
…edusajs#9428)

* chore: Processing filters deeply looking at the current joiner first

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @carlos-r-l-rodrigues