Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add metadata to product type resp #9515

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Oct 9, 2024

What

  • Adds metadata to the default response for /admin/product-types endpoints.
  • Fixes tests to expect correct shape and not use objectContaining.

Fixes CC-552

@srindom srindom requested a review from a team as a code owner October 9, 2024 13:43
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:44pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 1:44pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Oct 9, 2024 1:44pm
docs-ui ⬜️ Ignored (Inspect) Oct 9, 2024 1:44pm
docs-v2 ⬜️ Ignored (Inspect) Oct 9, 2024 1:44pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 1:44pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 1:44pm

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 0ddc391

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srindom srindom merged commit 7ec1743 into develop Oct 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants