You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes deprecated commands and code from the Medusa monorepo. Here's a quick summary of it. Please, feel free to review this PR thoroughly to ensure I am not breaking something by mistake :)
Commands removal
seed: There was no implementation for the seed command in the first place.
migrations [action]: Removed in favor of db:migrate, db:rollback and db:generate.
links [action]: Removed in favor of db:sync-links.
start-cluster: Removed start-cluster command in favor of the --cluster flag on the start command.
Config options removal
Remove config option databaseType as it is not used anywhere.
Remove config option httpCompression in favor of compression property.
Remove allowedFields in favor of allowed property from the MedusaRequest.
Remove expand property in favor of allowed property from the RequestQueryFields.
Remove defaultFields and defaultRelations in favor of defaults property from the RequestQueryFields.
Remove allowedFields and allowedRelations in favor of allowed property from the RequestQueryFields.
Events build changes
Remove eventsEnum in favor of eventName property accepted by the moduleEventBuilderFactory. Also updated all the usages to use eventName.
ModelDTO changes
Remove unused properties singular and plural from ModelDTOConfig.
Models template changes
Remove unused properties create, update, singular, and plural from ModelsConfigTemplate.
Zod validator changes
Remove unused OptionalBooleanValidator in favor of booleanString.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
not related to this PR, but the singularplural properties at some point will have to be added somewhere, as we auto generate methods based on them, non english names won't work, and non standard english plurals won't work properly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thetutlage
requested review from
olivermrbl,
a team,
adrien2p and
carlos-r-l-rodrigues
Fixes: FRMW-2736
This PR removes deprecated commands and code from the Medusa monorepo. Here's a quick summary of it. Please, feel free to review this PR thoroughly to ensure I am not breaking something by mistake :)
Commands removal
seed: There was no implementation for theseedcommand in the first place.migrations [action]: Removed in favor ofdb:migrate,db:rollbackanddb:generate.links [action]: Removed in favor ofdb:sync-links.start-cluster: Removedstart-clustercommand in favor of the--clusterflag on the start command.Config options removal
databaseTypeas it is not used anywhere.httpCompressionin favor ofcompressionproperty.allowedFieldsin favor ofallowedproperty from theMedusaRequest.expandproperty in favor ofallowedproperty from theRequestQueryFields.defaultFieldsanddefaultRelationsin favor ofdefaultsproperty from theRequestQueryFields.allowedFieldsandallowedRelationsin favor ofallowedproperty from theRequestQueryFields.Events build changes
eventsEnumin favor ofeventNameproperty accepted by themoduleEventBuilderFactory. Also updated all the usages to useeventName.ModelDTO changes
singularandpluralfromModelDTOConfig.Models template changes
create,update,singular, andpluralfromModelsConfigTemplate.Zod validator changes
OptionalBooleanValidatorin favor ofbooleanString.