-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard) taxes + discount breakdown #9586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
Looks good! Would suggest we make a small additional change in this PR if it's not too much work:
Specifically, if automatic_taxes: false then we should show something like: Item Subtotal - 8.00 DKK If automatic_taxes: true we should show something like: Item Total - 10.00 DKK The reason for this is that we always want to show the details in admin as they are likely shown to the customer. automatic_taxes helps us here as it signals whether the store at any moment in time showed prices to the customer without taxes. E.g., if automatic_taxes: false, then there was a period of time where the customer saw item prices without taxes - up until the point when the tax context was known. This likely also means that taxes is a separate line in the totals breakdown shown to the customer as opposed to being included. This is approach is for example common in the US. It might be that we will have to revise this decision in the future, but for now this should be a pretty good solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**What** - add tax breakdown to order details - display discount total and codes --- CLOSES CC-553
What
CLOSES CC-553