Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard,ui): Fix outline flash on FocusModal #9624

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Oct 16, 2024

What

  • Fixes an issue where the outline would flash on FocusModals when the focus was transferred to the modal.
  • Fixes an issue where the selected value of the combobox component was misaligned for single value comboboxes.

Resolves CC-604

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:51pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm
api-reference-v2 ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm
docs-ui ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm
docs-v2 ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm
medusa-docs ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm
resources-docs ⬜️ Ignored (Inspect) Oct 16, 2024 7:51pm

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 7371007

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit 6a6fd6e into develop Oct 17, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/modal-focus-flash branch October 17, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants