You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standardize provider identifier static property. Now all providers must have a static property identifier which will be used to register the provider into the module container.
The id in the providers configuration can still be provided in the defineConfig if some provider can have multiple instances (e.g stripe per region)
All provider id have been fixed in all modules to be properly generated (e.g pp_stripe_the-given-id or pp_stripe instead of pp_stripe_ or pp_stripe_undefined
Breaking changes
The provide id in region_provider_id might be broken after the provider are reloaded since their id have been fixed. You might need to update those manually or regenerate those link
The auth module providers have been also aligned to the convention of having identifier and eventually an id and their generated id will following the same convention
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I don't think this breaks the auth domain, because the ids specified in medusa-config.js in the platform project happen to be the same as the provider IDs.
I don't think this breaks the auth domain, because the ids specified in medusa-config.js in the platform project happen to be the same as the provider IDs.
-- In order to normalize and be consistent, now the auth also concatenate the identifier and id which was not the case before, that can be breaking too --
…PROVIDER' (medusajs#9636)
* chore: Update modules providers configuration with 'identifier' and 'PROVIDER'
* update check
* fix tests
* type
* normalize auth provider
* emailpass
* providers
---------
Co-authored-by: Carlos R. L. Rodrigues <[email protected]>
Co-authored-by: Carlos R. L. Rodrigues <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adrien2p
requested review from
christiananese,
carlos-r-l-rodrigues and
olivermrbl
What
identifierstatic property. Now all providers must have a static propertyidentifierwhich will be used to register the provider into the module container.idin the providers configuration can still be provided in the defineConfig if some provider can have multiple instances (e.g stripe per region)pp_stripe_the-given-idorpp_stripeinstead ofpp_stripe_orpp_stripe_undefinedBreaking changes
region_provider_idmight be broken after the provider are reloaded since their id have been fixed. You might need to update those manually or regenerate those link