Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard,types): Translate all OrderBy filters #9691

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Oct 21, 2024

Resolves CC-616

Note

  • I have added some missing fields to a couple of types, to resolve TS errors in the dashboard.
  • For the ApiKey types I have left the created_at, updated_at, etc. as type Date, as changing them to string, caused @medusajs/medusa to fail building. We need to clean up the types at a later time.

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 0f34e9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 0:58am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 0:58am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 0:58am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 0:58am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 0:58am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 0:58am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 0:58am

@kasperkristensen kasperkristensen changed the title feat(dashboard): Translate all OrderBy filers feat(dashboard,types): Translate all OrderBy filers Oct 21, 2024
@kasperkristensen kasperkristensen changed the title feat(dashboard,types): Translate all OrderBy filers feat(dashboard,types): Translate all OrderBy filters Oct 21, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 9f53683 into develop Oct 21, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/translate-order-by branch October 21, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants