Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API validation management issues #9693

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 21, 2024

What
Currently, the API validation layer is broken in both responsibilities and validation itself.
This pr introduce the following fixes and patterns:

  • Always create a *Fields schema that only takes care of defining the schema validation without effect
  • Use the previous point into the API schema validator including $and and $or capabilities plus the recursive effects
  • remove normalizeArray which does not have to exists since array are already treated as they should
  • Add recursive transformation to take into account $and and $or as well or any other similar operators
  • New util applyAndAndOrOperators to wrap the management of those operators and to be merged to an existing schema

Tasks

  • store domain
  • admin domain

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: df86edc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 7:40am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 22, 2024 7:40am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:40am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:40am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:40am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:40am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 7:40am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant