Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip caching if dir doesn't exist #109

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

spowelljr
Copy link
Collaborator

@spowelljr spowelljr commented Mar 21, 2023

Fixes #102

Check if the directory exists before trying to cache it, this will prevent error messages that can confuse the user. This is usually caused because we try caching the kicbase and ISO, but only one will exist, so the non-existing one throws a message when it fails to cache.

Before:

* Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
/home/runner/bin/minikube version --short
v1.29.0
isoError: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

After:

* Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
/home/runner/bin/minikube version --short
v1.29.0

@medyagh medyagh merged commit d38ff83 into medyagh:master Mar 22, 2023
@spowelljr spowelljr deleted the stopCacheErrors branch March 22, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching issues
2 participants