Add network-plugin option #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
tam/network
branch
3 times, most recently
from
cd2cf8f
to
4d2918f
Compare
|
@medyagh can you help to take a look whenever you have time, thanks a lot. |
spowelljr
approved these changes
Sep 28, 2022
10 tasks
|
I am so sorry for the delay @sayboras do you mind rebasing your PR |
sayboras
force-pushed
the
tam/network
branch
from
4d2918f
to
e5dbc11
Compare
Done and sorry for delay response, I am just back from leave. |
This commit is to add network-plugin option for the use case of testing CNI implementation with minikube in CI. As the coredns pod will not be ready withouth CNI, wait flag should be able to adjust accordingly. Signed-off-by: Tam Mach <[email protected]>
spowelljr
force-pushed
the
tam/network
branch
from
e5dbc11
to
b5dfd05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to add network-plugin option for the use case of testing
CNI implementation with minikube in CI
Signed-off-by: Tam Mach [email protected]