Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minikube --addons & --extra-config #41

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Support minikube --addons & --extra-config #41

merged 4 commits into from
Dec 2, 2022

Conversation

bushwhackr
Copy link
Contributor

  • Enable addons flag when setting up minikube
  • Upgraded actions/checkout

@bushwhackr bushwhackr changed the title Support minikube --addons flag Support minikube --addons & --extra-options (dup) Oct 20, 2022
@bushwhackr
Copy link
Contributor Author

Added extra options commit from #33

@bushwhackr bushwhackr changed the title Support minikube --addons & --extra-options (dup) Support minikube --addons & --extra-config (dup) Oct 20, 2022
Copy link

@florenciacomuzzi florenciacomuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bushwhackr
Copy link
Contributor Author

is there anything blocking the merging of this PR?

@medyagh
Copy link
Owner

medyagh commented Dec 2, 2022

bushwhackr thanks for this PR and sorry for the delay in the review

@medyagh medyagh merged commit 697f2b7 into medyagh:master Dec 2, 2022
@medyagh medyagh changed the title Support minikube --addons & --extra-config (dup) Support minikube --addons & --extra-config Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants