Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Insecure registry configuration (#49) #50

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add Insecure registry configuration (#49) #50

merged 1 commit into from
Jan 12, 2023

Conversation

radtriste
Copy link
Contributor

#49

@radtriste radtriste marked this pull request as draft December 15, 2022 08:51
@radtriste
Copy link
Contributor Author

@medyagh testing in progress

@radtriste
Copy link
Contributor Author

tested in https:/kiegroup/kogito-serverless-operator/actions/runs/3702516960/jobs/6273476716 successfully

@radtriste
Copy link
Contributor Author

cc @spowelljr

@radtriste radtriste marked this pull request as ready for review December 15, 2022 13:01
@medyagh
Copy link
Owner

medyagh commented Jan 3, 2023

@radtriste do you mind rebuilding the npm we just did some changes and please rebase your PR

@radtriste
Copy link
Contributor Author

@medyagh PR updated :)

spowelljr
spowelljr approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@spowelljr spowelljr merged commit ba2fc28 into medyagh:master Jan 12, 2023
@radtriste radtriste deleted the issue_49 branch January 13, 2023 08:10
@radtriste radtriste restored the issue_49 branch January 13, 2023 08:10
@radtriste
Copy link
Contributor Author

@spowelljr @medyagh Thank you for the merge !
Would it be possible to release this new version so we can use it in our GHA ?

@medyagh
Copy link
Owner

medyagh commented Jan 13, 2023

@radtriste sounds good I will do a release right now

@spowelljr
Copy link
Collaborator

@radtriste Just as a FYI if you always change your setup-minikube to use master to access changes on master that are not yet released.

medyagh/setup-minikube@latest -> medyagh/setup-minikube@master

@radtriste
Copy link
Contributor Author

@medyagh Thank you for the release, gonna use it !
@spowelljr I prefer to use a specific version, aka now v0.0.10 to avoid any future non backward change problems

@radtriste radtriste deleted the issue_49 branch January 16, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radtriste @medyagh @spowelljr