fix: Correct the format for start-args #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input args is expecting split key value pair, instead of whole '<key> <value>' format, hence we should split start-args accordingly. Without this change, we will face the below example error: ``` /usr/bin/chmod +x /home/runner/work/_temp/9526b1b6-7755-4e7d-abee-6ab1a86fd52e /home/runner/bin/minikube version --short v1.28.0 /home/runner/bin/minikube start --cni false --network-plugin cni --wait false --nodes 3 Error: unknown flag: --nodes 3 ``` Signed-off-by: Tam Mach <[email protected]>
|
@medyagh @spowelljr for your input and review, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input args is expecting split key value pair, instead of whole ' ' format, hence we should split start-args accordingly.
Without this change, we will face the below example error:
Signed-off-by: Tam Mach [email protected]
Testing
Testing was done by using forked repo in cilium/cilium#23099