Merge pull request #872 from meganz/hotfix/import-old-seen

#15770. Avoid to set SEEN back in history
meganz · May 22, 2020 · 735de77 · 735de77
2 parents 7ce1329 + 1db01dd
commit 735de77
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/chatd.cpp b/src/chatd.cpp
@@ -3481,7 +3481,16 @@ void Chat::onLastSeen(Id msgid, bool resend)
  return;
  }
  }
- // else --> msgid was found locally
+ else // msgid was found locally
+ {
+ // if both `msgid` and `mLastSeenId` are known and localy available, there's an index to compare
+ if (mLastSeenIdx != CHATD_IDX_INVALID && idx < mLastSeenIdx)
+ {
+ CHATID_LOG_WARNING("onLastSeen: ignoring attempt to set last seen msgid backwards. Current: %s Attempt: %s", ID_CSTR(mLastSeenId), ID_CSTR(msgid));
+ return; // `mLastSeenId` is newer than the received `msgid`
+ }
+ }
+
  assert(mLastSeenId.isValid());
 
  if (idx == mLastSeenIdx)