-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v2.2.0 #735
Merged
Merged
Release/v2.2.0 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increment chatd protocol version - Add + operator overload to add a string to COMMAND. In case of ADDREACTION command the payload length must be added as a uint8 but the existing operators added the payload length as a uint32.
- Replace reaction map by a vector to a new structure Reaction. This action will solve the problem to obtain the reactions in the same order as we received. - Add new methods to manage reactions in Messsage class
Functions str_to_a32 and a32_to_str has been moved to ::mega:Utils so we have to remove the strongvelope copies and DataTranslation class
Add left commands to opcodeToStr
The user that sends ADD/DELREACTION must be own user.
We need to clean all the reactions for the chatroom in cache, and clean reactions for the truncate message in RAM
…hat reacted to a message with a specific reaction has changed.
- Add widget to show reactions
- Clean all reactions upon reception of chat truncate
…be captured in promise - Code styling
The error code for unexisting reaction is now `ENOENT`
Error codes, style and namespaces
Additionally, add the SdkMutexGuard to MEGAchat
Add error messages for things going wrong
Mostly cosmetic ones. Nothing relevant
- Adjust documentation in Reaction struct
#13357. Improve rich link management
#12043. Chat reactions
Added getcontacts command for testing
#13128. Avoid notify terminating user participanting at reconnection state
Needs the branch of the same name in the SDK
…ggedin #13441. Avoid send messages witout being logged in
#12955. Improve url detector
#13599. Protect against calls without audio track
megaclc: Add -order parameter for exec_ls
alber2510
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
Feature #12043: Add functionality for message reactions (ADDREACTION/DELREACTION)
Fixed issues
Bug #13128: Avoid notify CALL_STATUS_TERMINATING_USER_PARTICIPATION during reconnection process
Bug #13441: Send messages before being logged in to chatd
Bug #13599: Crash during call without audio stream
Task #12955: Review url checker for rich link
Target app/s
Android & iOS apps