Release/v2.3.4 #870
Merged
Release/v2.3.4 #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force request ice server ips every reconnection
Build Turn sever json with all information provided by the api query
…s in automatic tests
Co-Authored-By: Sergio Hernández <[email protected]>
Review of public chats require: 1. `checkChatLink()` to get the `chatid` 2. `openChatPreview()` to login into chatd 3. Once logged-in, get emails of each participants 4. Once emails loaded, open chatroom and load messages 5. Once msgs loaded, close chatroom accordingly
#15051. Implement new chatd commands MSGIDTIMESTAMP and NEWMSGIDTIMESTAMP
- Avoid double test for resutl of `getIp()` - Avoid unnecessary test for `mIceServerProvider.empty()` - Check if karere client is terminated upon DNS resolution. - Adjust logs to be in the RTC channel.
When we edit a message we need to update the content of all pending editions for this msg, but we need to keep the update ts to avoid problems related with management of sending queue.
#12074. When a message of a chat is updated without an internet connection, the last message is not updated
#15563. Import SEEN from external cache
#15563. Hotfix for SEEN import (develop)
#14784. Reduce latency to connect a call
Translated error strings. Android Bindings
When a new message is received, but it is already SEEN, the `onChatNotification()` should not be called in case the message is still being decrypted. Once decrypted, a callback, if suitable, will be triggered.
I've just tested the truncate case. MEGAchat intermediate layer already checks the `msgid` exists in the given chatid, the SDK's check whether the `msgid` is not UNDEF. Sending a random `msgid` to API results on success on API (it doesn't check the id), but chatd does not post any new message. In consequence, truncates must be edits of existing messages at all times.
In case the message is being sending, the attempt to retrieve reactions for a given `msgxid` results in logging an error. Instead, if the msg has no reactions, simply skip the call.
If a msg is new for a client, it's received as NEWMSG even when it's a truncate.
…on-seen #15729. Avoid to notify about messages being decrypted
…tanciating #15667. Avoid access to attribute cache when it's uninitialized
#15580. Add new method to allow set a DND with a timestamps for global chats
#15082. MEGAclc improve preview chat link
#15741. Replace exit() call by abort()
Now that SEEN pointer can be imported from the NSE, it might be outdated compared with the SEEN pointer in the app. In that case, we need to skip any update of the SEEN pointer, of the count of unread messages, etc.
#15770. Avoid to set SEEN back in history
Add authorizationToken parameter to firstname and lastname methods
jnavarrom
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
Feature #14784: Reduce latency to connect a call
Related issues
Bug #12074: When a message of a chat is updated without an internet connection, the last message is not updated
Bug #13941: Android (270) SDK crash issue 2 in lws_ext_cb_active
Bug #15051: Message creation ts set by server for sender
Bug #15082: MEGAclc stack over flow
Bug #15581: Assert (msg->isSending()) failed in Chat::msgRemoveFromSending
Bug #15638: ERROR_TOOMANY doesn't have a associated string
Bug #15667: Crash due to users attribute cache not available (yet)
Bug #15729: Avoid to notify about messages being decrypted
Bug #15770: The app shows an outdated count of unread messages
Other/s
Task #15741: Replace exit() by abort() for iOS upon critical error
Target app/s