iOS bindings for chat reactions #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lhr000lhrmega
changed the title
…k/#12148-Chat-message-emoji-reactions
lancy-mega
reviewed
Aug 19, 2020
| @@ -921,6 +921,26 @@ - (void)removeUnsentMessageForChat:(uint64_t)chatId rowId:(uint64_t)rowId { | |||
| self.megaChatApi->removeUnsentMessage(chatId, rowId); | |||
| } | |||
|
|
|||
| - (void)addReactionForChat:(uint64_t)chatId messageId:(uint64_t)messageId reaction:(NSString *)reaction { | |||
| self.megaChatApi->addReaction(chatId, messageId, reaction ? [reaction UTF8String] : NULL); | |||
There was a problem hiding this comment.
Is it possible to replace
reaction ? [reaction UTF8String] : NULL
With
reaction.UTF8String
as performing any operation on nil would return nil. I think we don't have to check for the condition. Let me know your thoughts.
If it possible I think we can replace it everywhere on your PR.
There was a problem hiding this comment.
Yes, it is possible if reaction is nil it will pass NULL as parameter, so we can replace reaction ? [reaction UTF8String] : NULL with reaction.UTF8String
lancy-mega
reviewed
Aug 19, 2020
jnavarrom
reviewed
Sep 10, 2020
jnavarrom
reviewed
Sep 10, 2020
jnavarrom
reviewed
Sep 10, 2020
Co-authored-by: Lancy <[email protected]>
Use “get” only for methods that return objects and values indirectly.
jnavarrom
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.