fix(fastfile): trim trailing whitespaces and correct typo #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This is just a cleanup of some bad formatting and typos in the project's
fastfile
.No functional changes were made.
Does this close any currently open issues?
No.
Any relevant logs, error output, etc?
None.
Any other comments?
There are some problems in this project Ruby and Fastlane setup.
.ruby-version
file with a newer version and enforce a Ruby version management tool (e.g. RVM) to guarantee that every developer that runs the project is using the same version, as well as an up-to-date one.fastfile
. Traliling whitespace, inconsistent use of single and double quotes, inconsistent variable naming (some are snake cased and others are camel cased) are to name some. In this PR, I just fixed the most straightforward ones that don't enforce any specific linter/formatter. Although, I do suggest adopting a linter/formatter for your ruby files (e.g. Rubocop) and enforcing its use on pre-commit and pre-push hooks.I can open issues for these points, if you want.
Where has this been tested?
As this is not iOS/Swift related, I've just ran the
setup
lane to guarantee that thefastfile
properly compiles:bundle exec fastlane setup
Fastlane version:
fastlane (2.213.0)
(Same as inGemfile.lock
)Ruby Version: The oldest I could ran with:
ruby 2.6.7p197 (2021-04-05 revision 67941)
MEGA Version:
v10.3
(Latest)Best regards, João Pedro de Amorim.