Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Env::set_flags() and FlagSetMode #245

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Add Env::set_flags() and FlagSetMode #245

merged 2 commits into from
Mar 1, 2024

Conversation

hinto-janai
Copy link
Contributor

Implements #202.

This PR:

  1. Exposes mdb_env_set_flags() via FFI which gets used in...
  2. Env::set_flags() which enables/disables flags depending on...
  3. the FlagSetMode enum which is either Enable or Disable

@Kerollmops Kerollmops added this to the v0.20.0 milestone Mar 1, 2024
Kerollmops
Kerollmops approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR!
Merging!

@Kerollmops Kerollmops merged commit 1372597 into meilisearch:main Mar 1, 2024
8 checks passed
@hinto-janai hinto-janai deleted the flag branch March 1, 2024 13:16
@hinto-janai hinto-janai mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hinto-janai @Kerollmops