Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete index before creation in test macro #269

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Delete index before creation in test macro #269

merged 3 commits into from
Apr 25, 2022

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Apr 25, 2022 •
edited
Loading

Partial fixes of #238

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Apr 25, 2022
@bidoubiwa bidoubiwa requested a review from irevoire April 25, 2022 15:51
irevoire
irevoire approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Could you keep the issue open since it was about two things and only one is half-solved? 😁

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

🔒 Permission denied

Existing reviewers: click here to make bidoubiwa a reviewer

@bidoubiwa
Copy link
Contributor Author

bors merge 😡

@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Build succeeded:

@bors bors bot merged commit 4452f2c into main Apr 25, 2022
@bors bors bot deleted the delete_index_before_creation branch April 25, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @irevoire