Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops panicking when getting indexes #603

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

postmeback
Copy link
Contributor

@postmeback postmeback commented Jul 7, 2024

Sorry for the wrong heading. It actually enhances the request mentioned on 575.

Fixes: #575

Requesting the maintainers to have a look at it.

@irevoire irevoire changed the title Issues Fixed Stops panicking when getting indexes Jul 8, 2024
src/errors.rs Outdated Show resolved Hide resolved
@curquiza curquiza requested a review from irevoire July 11, 2024 08:15
@curquiza curquiza added the bug Something isn't working label Jul 25, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@postmeback can you fix the tests please?

src/errors.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
@postmeback
Copy link
Contributor Author

postmeback commented Jul 30, 2024

image

Two tests are failing after going through all the steps. Looking for assistance :)

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @postmeback, awesome thanks a lot for your contribution

@irevoire
Copy link
Member

irevoire commented Aug 1, 2024

bors merge

Copy link
Contributor

meili-bors bot commented Aug 1, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 6c5f295 into meilisearch:main Aug 1, 2024
7 checks passed
@postmeback
Copy link
Contributor Author

Yaay ! 🪁 🪁 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwrap causes panic instead of handling the Result
3 participants