Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synteny analysis #1386

Merged
merged 34 commits into from
Apr 1, 2020
Merged

Synteny analysis #1386

merged 34 commits into from
Apr 1, 2020

Conversation

mschecht
Copy link
Contributor

Hi Meren,

I added tests for anvi-analyze-synteny to run_all_tests.sh and reviewed the code of synteny.py, let me know if you have any suggestions.

Cheers,
Matt

Copy link
Member

@meren meren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt :) Great job. I had some extra minutes and I used my time to make some comments :)

bin/anvi-analyze-synteny Outdated Show resolved Hide resolved
anvio/__init__.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/synteny.py Outdated Show resolved Hide resolved
anvio/__init__.py Outdated Show resolved Hide resolved
@mschecht
Copy link
Contributor Author

@meren I wasn't quite sure about conventions for printing messages to the user. I thought it would be nice to report that anvi-analyze-synteny worked and where to find the output file. What do you think of this?

@meren
Copy link
Member

meren commented Mar 29, 2020

I think a single run.info that mentions the output file path would be enough. The line above is redundant with that information :)

bin/anvi-analyze-synteny Outdated Show resolved Hide resolved
@meren
Copy link
Member

meren commented Apr 1, 2020

Thanks for all the changes, @mschecht!

These will be in v6.2.

@meren meren merged commit bdf6e01 into master Apr 1, 2020
@meren meren deleted the synteny-analysis branch July 31, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants