Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buildpacks for building docker image #764

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Ch4s3r
Copy link
Contributor

@Ch4s3r Ch4s3r commented Jun 25, 2024

  • Use semantic-release github action
  • Use buildpack for optimized docker images
    • Only build amd64 image as arm is not supported by now from paketo buildpacks
    • smaller image size 350 vs 100mb now
    • publishes latest and versioned tag
  • Remove unnecessary matrix build from test
  • Add config to package.json that the package is public (as the github action fails to publish to npmjs otherwise with 402)

npmjs:
image
docker:
image

  • Test that merging PR creates new version
  • Add changelog entry

@Ch4s3r
Copy link
Contributor Author

Ch4s3r commented Jun 25, 2024

Always get this error:

An error occurred while running semantic-release: Error: Command failed with exit code 128: git tag v2.22.0 fcbbbb3152e4be8453cb4d03d8f8ad50f94cab4c
fatal: tag 'v2.22.0' already exists

Need to check how to skip it or why the tag is there.

Update: deleted all tags in the fork


permissions:
contents: read
on: [ push ]
Copy link
Contributor Author

@Ch4s3r Ch4s3r Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any reason why two triggers have been used?
As in the last example here they do it via push.

@Ch4s3r Ch4s3r marked this pull request as ready for review June 25, 2024 06:39
@Ch4s3r
Copy link
Contributor Author

Ch4s3r commented Jun 25, 2024

@shine2lay @jusx please have a look :)

@hemeroc
Copy link
Contributor

hemeroc commented Jul 29, 2024

Hi, that would be real cool to have.
@shine2lay @jusx is there any blocker for this?

@shine2lay shine2lay merged commit 05dfb80 into mergeability:master Jul 29, 2024
1 check passed
Copy link

🎉 This PR is included in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants