Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dayjs to ^1.11.9 and remove dayjs plugins from bundle #1229

Closed
ZeekoZhu opened this issue Oct 9, 2023 · 0 comments · Fixed by #1230 or #1232
Closed

upgrade dayjs to ^1.11.9 and remove dayjs plugins from bundle #1229

ZeekoZhu opened this issue Oct 9, 2023 · 0 comments · Fixed by #1230 or #1232
Assignees
@GerilLeto
Labels
bug Something isn't working scope:dashboard

Comments

@ZeekoZhu
Copy link
Contributor

ZeekoZhu commented Oct 9, 2023

We have identified an issue with the objectSupport plugin, which is a dependency of the devtable dashboard. The relevant discussion can be found in this pull request: Day.js Pull Request #2334.

The dashboard incorporates this plugin into the distributed bundle, as seen in the following line of code in the vite.config.ts Line #25
@GerilLeto GerilLeto self-assigned this Oct 9, 2023
@GerilLeto GerilLeto added scope:dashboard enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 9, 2023
@GerilLeto GerilLeto linked a pull request Oct 9, 2023 that will close this issue
1229 upgrade dayjs to 1119 and remove dayjs plugins from bundle #1230
Merged
@GerilLeto GerilLeto reopened this Oct 10, 2023
ZeekoZhu added a commit that referenced this issue Oct 10, 2023
@ZeekoZhu
chore: fix dayjs plugin bundle problem
6b75af9 
fix #1229
@ZeekoZhu ZeekoZhu mentioned this issue Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerilLeto GerilLeto

Labels
bug Something isn't working scope:dashboard
Projects
None yet
Milestone
No milestone
2 participants
@GerilLeto @ZeekoZhu