Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps remove --force should not fail if the app doesn't exist #792

Open
hariso opened this issue Jul 18, 2023 · 0 comments
Open

apps remove --force should not fail if the app doesn't exist #792

hariso opened this issue Jul 18, 2023 · 0 comments

Comments

@hariso
Copy link
Contributor

hariso commented Jul 18, 2023

meroxa apps remove myAppName --force fails if myAppName doesn't exist. An advantage of that is that it lets the user know that myAppName doesn't exist, even though a user may have expected it to be there.

On the other hand, the intended goal is not to have an application. If it doesn't exist, then the goal is achieved, so returning an error isn't needed.

Is your feature request related to a problem? Please describe.
Not really.

Describe the solution you'd like
apps remove --force should not fail if the app doesn't exist.

Describe alternatives you've considered
Keeping existing behavior has its advantages.

Additional context
In my case, I'm using apps remove only to redeploy an app, and in that context, the fact that an app doesn't exist is not of concern.

It's also in line with what Linux's rm works: rm --force doesn't return an error if the file/directory to be removed doesn't exist. Based on that, I believe apps remove --force would be closer to user expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant