Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit status button width, fix hover states #543

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

setphen
Copy link
Contributor

@setphen setphen commented Jan 2, 2021

This removes the explicit 20px width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.

before

Kapture 2021-01-01 at 19 56 11

after

Kapture 2021-01-01 at 19 57 50

This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
Copy link
Contributor

@SomniusTiger SomniusTiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks for making these changes!

@SomniusTiger SomniusTiger merged commit 9ed11e2 into merveilles:merveilles Jan 2, 2021
SomniusTiger pushed a commit that referenced this pull request Apr 4, 2021
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request May 17, 2021
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Aug 27, 2021
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Feb 10, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Apr 3, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request May 7, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request May 10, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Nov 30, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Dec 19, 2022
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Jan 26, 2023
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Jun 2, 2023
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Jul 6, 2023
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Jul 8, 2023
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Dec 26, 2023
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Feb 2, 2024
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
SomniusTiger pushed a commit that referenced this pull request Feb 21, 2024
This removes the explicit width for icon buttons, which was cutting off
part of the SVG background, and fixes the hover states by moving the
:hover rule to the parent element's selector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants