Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add a howto page on debug builds #466

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

rgommers
Copy link
Contributor

@rgommers rgommers commented Sep 1, 2023

Closes gh-461
Closes gh-207
Also xref gh-459 and gh-441 which are already closed but contain discussion relevant to debug builds.

@rgommers rgommers added the documentation Improvements or additions to documentation label Sep 1, 2023
@WillAyd
Copy link

WillAyd commented Sep 1, 2023

Looks nice!

******************

For development work on native code in your Python package, you may want to use
a debug build. To do so, we need to use the ``buildtype`` argument, which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it?

Suggested change
a debug build. To do so, we need to use the ``buildtype`` argument, which is
a debug build. To do so, we need to use the ``buildtype=debug`` argument, which is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was calling buildtype the argument, and I'd consider debug its value. The full invocation is given on the pip install line further down.

I don't have a strong preference here - the way I have it now seems more concise to me, but it could also be buildtype=debug or -Dbuildtype=debug.

Copy link
Member

@dnicolodi dnicolodi Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write either "buildtype option" (preferred) or "-Dbuildtype=debug argument".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "buildtype option"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, perhaps I was unclear; you have "the buildtype option, which is equivalent to -Ddebug=true -Doptimization=0", which is not directly exactly true. It is buildtype=debug which is equivalent to those two settings; buildtype by itself is equivalent to many combinations of those options.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Indeed, the sentence as it reads now is not precise. I'll fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @QuLogic, thanks. The fix is included as part of gh-476.

@dnicolodi
Copy link
Member

I usually prefer the impersonal form for documentation, but it may just be a professional bias, thus it is ok this way too. Otherwise I just have a couple of minor comments.

Closes mesonbuildgh-461
Closes mesonbuildgh-207
Also xref mesonbuildgh-459 and mesonbuildgh-441 which are already closed but contain
discussion relevant to debug builds.
@rgommers
Copy link
Contributor Author

rgommers commented Sep 2, 2023

I usually prefer the impersonal form for documentation

I usually prefer this form, and I also think it's fine either way. As long as individual pages are consistent so it doesn't look too messy.

@rgommers rgommers added this to the v0.14.0 milestone Sep 2, 2023
@dnicolodi dnicolodi merged commit ed82060 into mesonbuild:main Sep 2, 2023
11 checks passed
@rgommers rgommers deleted the doc-debug-builds branch September 2, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to get a debug build Building with a debug python build should generate a debug build
4 participants