-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add a howto page on debug builds #466
Conversation
Looks nice! |
docs/how-to-guides/debug-builds.rst
Outdated
****************** | ||
|
||
For development work on native code in your Python package, you may want to use | ||
a debug build. To do so, we need to use the ``buildtype`` argument, which is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it?
a debug build. To do so, we need to use the ``buildtype`` argument, which is | |
a debug build. To do so, we need to use the ``buildtype=debug`` argument, which is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was calling buildtype
the argument, and I'd consider debug
its value. The full invocation is given on the pip install
line further down.
I don't have a strong preference here - the way I have it now seems more concise to me, but it could also be buildtype=debug
or -Dbuildtype=debug
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write either "buildtype option" (preferred) or "-Dbuildtype=debug argument".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to "buildtype
option"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, perhaps I was unclear; you have "the buildtype
option, which is equivalent to -Ddebug=true -Doptimization=0
", which is not directly exactly true. It is buildtype=debug
which is equivalent to those two settings; buildtype
by itself is equivalent to many combinations of those options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Indeed, the sentence as it reads now is not precise. I'll fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually prefer the impersonal form for documentation, but it may just be a professional bias, thus it is ok this way too. Otherwise I just have a couple of minor comments. |
Closes mesonbuildgh-461 Closes mesonbuildgh-207 Also xref mesonbuildgh-459 and mesonbuildgh-441 which are already closed but contain discussion relevant to debug builds.
44d97fb
to
b0e9288
Compare
I usually prefer this form, and I also think it's fine either way. As long as individual pages are consistent so it doesn't look too messy. |
Closes gh-461
Closes gh-207
Also xref gh-459 and gh-441 which are already closed but contain discussion relevant to debug builds.