Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: prepare changelog for 0.14.0 release #474

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

dnicolodi
Copy link
Member

I've started to put together the changelog entry for the next release.

@rgommers rgommers added the documentation Improvements or additions to documentation label Sep 3, 2023
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnicolodi! Looks good overall - a few comments and suggestions.

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Show resolved Hide resolved
@rgommers rgommers added this to the v0.14.0 milestone Sep 3, 2023
@dnicolodi
Copy link
Member Author

I've implemented all suggestions. I also added an entry bout meson install after all, and reordered the entries to be grouped more logically, instead of being sorted by implementation date, which is irrelevant to the reader.

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks.

Regarding handling of meson install options by meson-python, we should probably explicitly list the ones we recognize in https://meson-python.readthedocs.io/en/latest/reference/pyproject-settings.html#cmdoption-arg-tool.meson-python.args.install. Most of the missing ones aren't relevant, but it's possible --strip may be or some new option gets added to meson install that we must start handling. WDYT?

@rgommers rgommers merged commit 56187f2 into mesonbuild:main Sep 4, 2023
11 checks passed
@dnicolodi
Copy link
Member Author

Good idea, but we describe a way to pass arguments to meson install also here https://meson-python.readthedocs.io/en/latest/reference/config-settings.html#cmdoption-arg-install-args

@rgommers
Copy link
Contributor

rgommers commented Sep 4, 2023

Ah forgot we already have an issue: gh-473. I'll comment there.

@dnicolodi
Copy link
Member Author

I've beaten you to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants