Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: bump minimum required pyproject-metadata version to 0.8.0 #613

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dnicolodi
Copy link
Member

No description provided.

@dnicolodi dnicolodi force-pushed the pyproject-metadata-08 branch 3 times, most recently from 3f99f81 to 90dc785 Compare April 15, 2024 20:53
@dnicolodi dnicolodi marked this pull request as draft April 15, 2024 21:58
@dnicolodi dnicolodi force-pushed the pyproject-metadata-08 branch 2 times, most recently from d1da1af to e97a3fe Compare April 25, 2024 17:59
@dnicolodi dnicolodi changed the title MAINT: remove workarounds for bugs fixed in pyproject-metadata 0.8.0 MAINT: bump minimum required pyproject-metadata version to 0.8.0 Apr 25, 2024
@dnicolodi
Copy link
Member Author

This is ready to merge when we are ready to bump the minimum required pyproject-metadata version.

@rgommers
Copy link
Contributor

rgommers commented May 1, 2024

I think it's okay to bump to a fairly recent version. PDM and scikit-build-core now both vendor pyproject-metadata, so it doesn't seem likely that we'll cause problems for anyone in pretty aggressively requiring the most recent version.

It may be useful to check pyproject_metadata.__version__ to guard against potential mismatches? It's easy for distros to miss keeping their dependency metadata for meson-python fully in sync, and if we somehow pick up a pyproject_metadata 0.7.1 somewhere, it could otherwise yield confusing errors.

@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label Aug 2, 2024
@rgommers
Copy link
Contributor

It's been 6 months, so I think this can be merged now after a small update to resolve the merge conflict, and possibly add the below check:

It may be useful to check pyproject_metadata.__version__ to guard against potential mismatches?

@dnicolodi
Copy link
Member Author

I think it could be useful to cut a release (let's call it 0.16.1 or 0.17.0) before merging this. There are a couple of bug fixes on main that it would be nice to get out with minimal effort from distributors. I can prepare the release.

I'm not convinced that we should start verifying the version of all dependencies, just because someone may have done a poor job in packaging. We haven't checked that pyproject-metadata is version 0.7.1 or later so far, thus adding a check for version 0.8.0 or later should not be necessary either. We check for ninja and meson versions because these are not Python libraries and we had evidence of the wrong ones being picked up because of $PATH being set incorrectly.

@rgommers
Copy link
Contributor

Good point, +1 for doing a release first.

Okay, fair enough re version check - we can always add it later in case bug reports show a real-world need.

@dnicolodi
Copy link
Member Author

I've prepared the release, see #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular code improvements that are not new features nor end-user-visible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants