Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add OpenBLAS wrap #1734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ENH: Add OpenBLAS wrap #1734

wants to merge 1 commit into from

Conversation

HaoZeke
Copy link

@HaoZeke HaoZeke commented Oct 5, 2024

OpenBLAS is absolutely massive; but this seems to be a reasonable starting point for seeing wider use. We support a bunch of configurations seen here [1] (but only for dynamic builds, which should be the use case for subproject usage anyway).
The project will eventually be upstreamed if enough adoption takes place, and progress can be tracked on the forked repo from whence this is generated [2].
Tests pass on CI for Windows [3], Linux and MacOS [4]; for a reasonable set of baseline architectures.

This is a squashed single-commit contribution representing commits by me (@HaoZeke), @mtsokol and @rgommers.

Extraction from the branch is done via rsync, basically:

rsync -zarv --prune-empty-dirs --include="*/" --include="meson_options.txt" --exclude="*" $SDIR/ $DDIR
rsync -zarv --prune-empty-dirs --include="*/" --include="meson.build" --exclude="*" $SDIR/ $DDIR
# Remove benchmarks

Along with some manual copies of additional scripts and .c files only needed for the meson build.

As a complex project with a plethora of options, any suggestions are also welcome (maybe best expressed via issues on the fork [2]).

[1] https:/HaoZeke/OpenBLAS/blob/mesonBasic/meson_options.txt
[2] https:/HaoZeke/OpenBLAS/tree/mesonBasic
[3] https:/HaoZeke/OpenBLAS/blob/mesonBasic/.github/workflows/meson.yml
[4] https:/HaoZeke/OpenBLAS/blob/mesonBasic/.github/workflows/meson_linux_darwin.yml

@HaoZeke HaoZeke force-pushed the opblas branch 3 times, most recently from 90f3c4d to e7886a6 Compare October 5, 2024 22:07
@jpakkane
Copy link
Member

jpakkane commented Oct 5, 2024

WARNING: Variable 'openblas_dep' in the subproject 'subprojects/OpenBLAS-0.3.28' is not found

@HaoZeke HaoZeke force-pushed the opblas branch 2 times, most recently from 9846bde to acf7285 Compare October 5, 2024 22:47
@HaoZeke
Copy link
Author

HaoZeke commented Oct 5, 2024

WARNING: Variable 'openblas_dep' in the subproject 'subprojects/OpenBLAS-0.3.28' is not found

Sorry, checked via tools/sanity_checks.pynow.

Co-authored-by: mtsokol <[email protected]>
Co-authored-by: rgommers <[email protected]>
@jpakkane
Copy link
Member

ERROR: Unknown compiler(s): [['gfortran'], ['flang'], ['nvfortran'], ['pgfortran'], ['ifort'], ['ifx'], ['g95']]

You need to edit ci_config.json to add the Debian packages needed to build this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants